diff --git a/java/src/org/broadinstitute/sting/gatk/walkers/recalibration/CovariateCounterWalker.java b/java/src/org/broadinstitute/sting/gatk/walkers/recalibration/CovariateCounterWalker.java index 4332a6def..f56a43c0b 100755 --- a/java/src/org/broadinstitute/sting/gatk/walkers/recalibration/CovariateCounterWalker.java +++ b/java/src/org/broadinstitute/sting/gatk/walkers/recalibration/CovariateCounterWalker.java @@ -110,7 +110,7 @@ public class CovariateCounterWalker extends LocusWalker { private long countedBases = 0; // Number of bases used in the calculations, used for reporting in the output file private long skippedSites = 0; // Number of loci skipped because it was a dbSNP site, used for reporting in the output file private int numUnprocessed = 0; // Number of consecutive loci skipped because we are only processing every Nth site - private final String versionNumber = "2.0.4"; // Major version, minor version, and build number + private final String versionString = "v2.0.4"; // Major version, minor version, and build number private Pair dbSNP_counts = new Pair(0L, 0L); // mismatch/base counts for dbSNP loci private Pair novel_counts = new Pair(0L, 0L); // mismatch/base counts for non-dbSNP loci private static final double DBSNP_VS_NOVEL_MISMATCH_RATE = 2.0; // rate at which dbSNP sites (on an individual level) mismatch relative to novel sites (determined by looking at NA12878) @@ -130,7 +130,7 @@ public class CovariateCounterWalker extends LocusWalker { */ public void initialize() { - logger.info( "CovariateCounterWalker version: " + versionNumber ); + logger.info( "CovariateCounterWalker version: " + versionString ); // Get a list of all available covariates final List> classes = PackageUtils.getClassesImplementingInterface( Covariate.class ); @@ -312,7 +312,7 @@ public class CovariateCounterWalker extends LocusWalker { throw new RuntimeException(String.format("Value encoded by %s in %s isn't a string!", RecalDataManager.ORIGINAL_QUAL_ATTRIBUTE_TAG, read.getReadName())); } } - bases = read.getReadBases(); // BUGBUG: DinucCovariate is relying on this method returning the same byte for bases 'a' and 'A'. Is this true? + bases = read.getReadBases(); // BUGBUG: DinucCovariate is relying on this method returning the same byte for bases 'a' and 'A'. isNegStrand = read.getReadNegativeStrandFlag(); final SAMReadGroupRecord readGroup = read.getReadGroup(); if( readGroup == null ) { diff --git a/java/src/org/broadinstitute/sting/gatk/walkers/recalibration/RecalDataManager.java b/java/src/org/broadinstitute/sting/gatk/walkers/recalibration/RecalDataManager.java index 57dbf902b..87d607b44 100644 --- a/java/src/org/broadinstitute/sting/gatk/walkers/recalibration/RecalDataManager.java +++ b/java/src/org/broadinstitute/sting/gatk/walkers/recalibration/RecalDataManager.java @@ -168,6 +168,9 @@ public class RecalDataManager { dataSumExpectedErrors.clear(); dataCollapsedReadGroup.clear(); dataCollapsedQualityScore.clear(); + for( int iii = 0; iii < numCovariates - 2; iii++ ) { + dataCollapsedByCovariate.get(iii).clear(); + } dataCollapsedByCovariate.clear(); dataSumExpectedErrors = null; // Will never need this table again dataCollapsedReadGroup = null; // Will never need this table again diff --git a/java/src/org/broadinstitute/sting/gatk/walkers/recalibration/TableRecalibrationWalker.java b/java/src/org/broadinstitute/sting/gatk/walkers/recalibration/TableRecalibrationWalker.java index 9cd60c2a1..4a7cf91cf 100644 --- a/java/src/org/broadinstitute/sting/gatk/walkers/recalibration/TableRecalibrationWalker.java +++ b/java/src/org/broadinstitute/sting/gatk/walkers/recalibration/TableRecalibrationWalker.java @@ -1,7 +1,6 @@ package org.broadinstitute.sting.gatk.walkers.recalibration; import net.sf.samtools.*; -import net.sf.picard.reference.ReferenceSequenceFileFactory; import org.broadinstitute.sting.gatk.walkers.ReadWalker; import org.broadinstitute.sting.gatk.walkers.WalkerName; import org.broadinstitute.sting.gatk.walkers.Requires; @@ -66,8 +65,8 @@ public class TableRecalibrationWalker extends ReadWalker> classes = PackageUtils.getClassesImplementingInterface(Covariate.class); @@ -216,17 +216,20 @@ public class TableRecalibrationWalker extends ReadWalker