From d0cf8bcc8096bf0fc03bbe57ec564cb84c7bea2b Mon Sep 17 00:00:00 2001 From: Joel Thibault Date: Fri, 22 Jun 2012 16:01:15 -0400 Subject: [PATCH] Add unit tests for VariantContextBuilder.rmAttribute() and .attribute() * These generated NPEs when the attribute object is null --- .../utils/variantcontext/VariantContextUnitTest.java | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/public/java/test/org/broadinstitute/sting/utils/variantcontext/VariantContextUnitTest.java b/public/java/test/org/broadinstitute/sting/utils/variantcontext/VariantContextUnitTest.java index 7b8205e5b..1d290118f 100755 --- a/public/java/test/org/broadinstitute/sting/utils/variantcontext/VariantContextUnitTest.java +++ b/public/java/test/org/broadinstitute/sting/utils/variantcontext/VariantContextUnitTest.java @@ -757,12 +757,18 @@ public class VariantContextUnitTest extends BaseTest { modified = new VariantContextBuilder(cfg.vc).filters(newFilters).make(); Assert.assertEquals(modified.getFilters(), newFilters); + // test the behavior when the builder's attribute object is null + modified = new VariantContextBuilder(modified).attributes(null).make(); + Assert.assertTrue(modified.getAttributes().isEmpty()); + modified = new VariantContextBuilder(modified).attributes(null).rmAttribute("AC").make(); + Assert.assertTrue(modified.getAttributes().isEmpty()); + modified = new VariantContextBuilder(modified).attributes(null).attribute("AC", 1).make(); + Assert.assertEquals(modified.getAttribute("AC"), 1); + modified = new VariantContextBuilder(cfg.vc).attribute("AC", 1).make(); Assert.assertEquals(modified.getAttribute("AC"), 1); modified = new VariantContextBuilder(modified).attribute("AC", 2).make(); Assert.assertEquals(modified.getAttribute("AC"), 2); - modified = new VariantContextBuilder(modified).attributes(null).make(); - Assert.assertTrue(modified.getAttributes().isEmpty()); Genotype g1 = GenotypeBuilder.create("AA2", Arrays.asList(Aref, Aref)); Genotype g2 = GenotypeBuilder.create("AT2", Arrays.asList(Aref, T));