From a22e7a5358ee9a2e8a8475b75867e1468fbd2bbc Mon Sep 17 00:00:00 2001 From: Eric Banks Date: Thu, 16 Aug 2012 15:07:32 -0400 Subject: [PATCH] Should've run 'ant clean' instead of just 'ant'. In any event, these are 2 cases where we are setting a class's internal static variable directly. Very dangerous. --- public/java/src/org/broadinstitute/sting/utils/baq/BAQ.java | 2 +- .../sting/utils/variantcontext/GenotypeBuilder.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/public/java/src/org/broadinstitute/sting/utils/baq/BAQ.java b/public/java/src/org/broadinstitute/sting/utils/baq/BAQ.java index f37451cba..439a0d8ed 100644 --- a/public/java/src/org/broadinstitute/sting/utils/baq/BAQ.java +++ b/public/java/src/org/broadinstitute/sting/utils/baq/BAQ.java @@ -68,7 +68,7 @@ public class BAQ { } // Phred scaled now (changed 1/10/2011) - public static final double DEFAULT_GOP = 40; + public static double DEFAULT_GOP = 40; /* Takes a Phred Scale quality score and returns the error probability. * diff --git a/public/java/src/org/broadinstitute/sting/utils/variantcontext/GenotypeBuilder.java b/public/java/src/org/broadinstitute/sting/utils/variantcontext/GenotypeBuilder.java index c18f954a2..e3bef6bc5 100755 --- a/public/java/src/org/broadinstitute/sting/utils/variantcontext/GenotypeBuilder.java +++ b/public/java/src/org/broadinstitute/sting/utils/variantcontext/GenotypeBuilder.java @@ -53,7 +53,7 @@ import java.util.*; */ @Invariant({"alleles != null"}) public final class GenotypeBuilder { - public static final boolean MAKE_FAST_BY_DEFAULT = true; + public static boolean MAKE_FAST_BY_DEFAULT = true; private String sampleName = null; private List alleles = Collections.emptyList();