zzh
/
gatk-3.8
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

UserException fixes for GATK_logs recent errors 

-- SamFileReader.java:525
-- BlockCompressedInputStream:376

These were both instances were we weren't catching and rethrowing picard exceptions as UserExceptions.
This commit is contained in:
Mark DePristo 2012-04-10 07:37:42 -04:00
parent 8507cd7440
commit 6885e2d065
1 changed files with 15 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
public/java/src/org/broadinstitute/sting/gatk/datasources/reads/SAMDataSource.java
View File

@ -51,11 +51,10 @@ import org.broadinstitute.sting.utils.recalibration.BaseRecalibration;
import org.broadinstitute.sting.utils.sam.GATKSamRecordFactory; import org.broadinstitute.sting.utils.sam.GATKSamRecordFactory;
import java.io.File; import java.io.File;
import java.io.FileNotFoundException;
import java.lang.reflect.InvocationTargetException; import java.lang.reflect.InvocationTargetException;
import java.lang.reflect.Method; import java.lang.reflect.Method;
import java.util.*; import java.util.*;
import java.util.concurrent.*; import java.util.concurrent.Callable;
/** /**
* User: aaron * User: aaron
@ -474,7 +473,6 @@ public class SAMDataSource {
/** /**
* Fill the given buffering shard with reads. * Fill the given buffering shard with reads.
* @param shard Shard to fill. * @param shard Shard to fill.
* @return true if at the end of the stream. False otherwise.
*/ */
public void fillShard(Shard shard) { public void fillShard(Shard shard) {
if(!shard.buffersReads()) if(!shard.buffersReads())
@ -569,15 +567,19 @@ public class SAMDataSource {
if(shard.getFileSpans().get(id) == null) if(shard.getFileSpans().get(id) == null)
throw new ReviewedStingException("SAMDataSource: received null location for reader " + id + ", but null locations are no longer supported."); throw new ReviewedStingException("SAMDataSource: received null location for reader " + id + ", but null locations are no longer supported.");
if(threadAllocation.getNumIOThreads() > 0) { try {
BlockInputStream inputStream = readers.getInputStream(id); if(threadAllocation.getNumIOThreads() > 0) {
inputStream.submitAccessPlan(new BAMAccessPlan(id, inputStream, (GATKBAMFileSpan) shard.getFileSpans().get(id))); BlockInputStream inputStream = readers.getInputStream(id);
BAMRecordCodec codec = new BAMRecordCodec(getHeader(id),factory); inputStream.submitAccessPlan(new BAMAccessPlan(id, inputStream, (GATKBAMFileSpan) shard.getFileSpans().get(id)));
codec.setInputStream(inputStream); BAMRecordCodec codec = new BAMRecordCodec(getHeader(id),factory);
iterator = new BAMCodecIterator(inputStream,readers.getReader(id),codec); codec.setInputStream(inputStream);
} iterator = new BAMCodecIterator(inputStream,readers.getReader(id),codec);
else { }
iterator = readers.getReader(id).iterator(shard.getFileSpans().get(id)); else {
iterator = readers.getReader(id).iterator(shard.getFileSpans().get(id));
}
} catch ( RuntimeException e ) { // we need to catch RuntimeExceptions here because the Picard code is throwing them (among SAMFormatExceptions) sometimes
throw new UserException.MalformedBAM(id.samFile, e.getMessage());
} }
iterator = new MalformedBAMErrorReformatingIterator(id.samFile, iterator); iterator = new MalformedBAMErrorReformatingIterator(id.samFile, iterator);
@ -932,10 +934,7 @@ public class SAMDataSource {
blockInputStream = new BlockInputStream(dispatcher,readerID,false); blockInputStream = new BlockInputStream(dispatcher,readerID,false);
reader = new SAMFileReader(readerID.samFile,indexFile,false); reader = new SAMFileReader(readerID.samFile,indexFile,false);
} catch ( RuntimeIOException e ) { } catch ( RuntimeIOException e ) {
if ( e.getCause() != null && e.getCause() instanceof FileNotFoundException ) throw new UserException.CouldNotReadInputFile(readerID.samFile, e);
throw new UserException.CouldNotReadInputFile(readerID.samFile, e);
else
throw e;
} catch ( SAMFormatException e ) { } catch ( SAMFormatException e ) {
throw new UserException.MalformedBAM(readerID.samFile, e.getMessage()); throw new UserException.MalformedBAM(readerID.samFile, e.getMessage());
} }