diff --git a/public/java/test/org/broadinstitute/sting/gatk/walkers/qc/TestVariantContextWalker.java b/public/java/test/org/broadinstitute/sting/gatk/walkers/qc/TestVariantContextWalker.java index 181516f33..6bb764f44 100755 --- a/public/java/test/org/broadinstitute/sting/gatk/walkers/qc/TestVariantContextWalker.java +++ b/public/java/test/org/broadinstitute/sting/gatk/walkers/qc/TestVariantContextWalker.java @@ -117,7 +117,7 @@ public class TestVariantContextWalker extends RodWalker { } private static VCFHeader createVCFHeader(VariantContext vc) { - return new VCFHeader(new HashSet(), vc.getGenotypes().getSampleNamesSorted()); + return new VCFHeader(new HashSet(), vc.getGenotypes().getSampleNamesOrderedByName()); } public Integer reduceInit() { diff --git a/public/java/test/org/broadinstitute/sting/utils/variantcontext/VariantContextBenchmark.java b/public/java/test/org/broadinstitute/sting/utils/variantcontext/VariantContextBenchmark.java index 7ad2c5c1b..06ce61627 100644 --- a/public/java/test/org/broadinstitute/sting/utils/variantcontext/VariantContextBenchmark.java +++ b/public/java/test/org/broadinstitute/sting/utils/variantcontext/VariantContextBenchmark.java @@ -49,7 +49,7 @@ public class VariantContextBenchmark extends SimpleBenchmark { @Param({"READ", "READ_SUBSET"}) Operation operation; // set automatically by framework - @Param({"OF_GENOTYPES", "OF_SAMPLES"}) + @Param({"OF_SAMPLES"}) SubContextOp subContextOp; // set automatically by framework private String INPUT_STRING; @@ -60,7 +60,6 @@ public class VariantContextBenchmark extends SimpleBenchmark { } public enum SubContextOp { - OF_GENOTYPES, OF_SAMPLES } @@ -91,7 +90,7 @@ public class VariantContextBenchmark extends SimpleBenchmark { codec.readHeader(lineReader); int counter = 0; - List samples = null; + Set samples = null; while (counter++ < linesToRead ) { String line = lineReader.readLine(); if ( line == null ) @@ -99,7 +98,7 @@ public class VariantContextBenchmark extends SimpleBenchmark { VariantContext vc = (VariantContext)codec.decode(line); if ( samples == null ) { - samples = new ArrayList(vc.getSampleNames()).subList(0, nSamplesToTake); + samples = new HashSet(new ArrayList(vc.getSampleNames()).subList(0, nSamplesToTake)); } if ( op == Operation.READ_SUBSET) @@ -119,13 +118,10 @@ public class VariantContextBenchmark extends SimpleBenchmark { CaliperMain.main(VariantContextBenchmark.class, args); } - private static final void processOneVC(VariantContext vc, List samples, SubContextOp subop) { + private static final void processOneVC(VariantContext vc, Set samples, SubContextOp subop) { VariantContext sub; switch ( subop ) { - case OF_GENOTYPES: - sub = vc.subContextFromGenotypes(vc.getGenotypes(samples).values(), vc.getAlleles()); - break; case OF_SAMPLES: sub = vc.subContextFromSamples(samples, vc.getAlleles()); break; diff --git a/public/java/test/org/broadinstitute/sting/utils/variantcontext/VariantContextUnitTest.java b/public/java/test/org/broadinstitute/sting/utils/variantcontext/VariantContextUnitTest.java index 77980267c..8d5505c0e 100755 --- a/public/java/test/org/broadinstitute/sting/utils/variantcontext/VariantContextUnitTest.java +++ b/public/java/test/org/broadinstitute/sting/utils/variantcontext/VariantContextUnitTest.java @@ -431,12 +431,12 @@ public class VariantContextUnitTest extends BaseTest { Genotype g5 = new Genotype("--", Arrays.asList(del, del), 10); VariantContext vc = new VariantContext("test", snpLoc,snpLocStart, snpLocStop , alleles, Arrays.asList(g1,g2,g3,g4,g5)); - VariantContext vc12 = vc.subContextFromGenotypes(Arrays.asList(g1,g2)); - VariantContext vc1 = vc.subContextFromGenotypes(Arrays.asList(g1)); - VariantContext vc23 = vc.subContextFromGenotypes(Arrays.asList(g2, g3)); - VariantContext vc4 = vc.subContextFromGenotypes(Arrays.asList(g4)); - VariantContext vc14 = vc.subContextFromGenotypes(Arrays.asList(g1, g4)); - VariantContext vc5 = vc.subContextFromGenotypes(Arrays.asList(g5)); + VariantContext vc12 = vc.subContextFromSamples(new HashSet(Arrays.asList(g1.getSampleName(),g2.getSampleName()))); + VariantContext vc1 = vc.subContextFromSamples(new HashSet(Arrays.asList(g1.getSampleName()))); + VariantContext vc23 = vc.subContextFromSamples(new HashSet(Arrays.asList(g2.getSampleName(), g3.getSampleName()))); + VariantContext vc4 = vc.subContextFromSamples(new HashSet(Arrays.asList(g4.getSampleName()))); + VariantContext vc14 = vc.subContextFromSamples(new HashSet(Arrays.asList(g1.getSampleName(), g4.getSampleName()))); + VariantContext vc5 = vc.subContextFromSamples(new HashSet(Arrays.asList(g5.getSampleName()))); Assert.assertTrue(vc12.isPolymorphic()); Assert.assertTrue(vc23.isPolymorphic());