zzh
/
gatk-3.8
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Changing locking errors to warnings. This will hopefully allow us to diagnose 

the mysterious failure in STING_INTEGRATION-3832, the next time it appears.


git-svn-id: file:///humgen/gsa-scr1/gsa-engineering/svn_contents/trunk@5164 348d0f76-0448-11de-a6fe-93d51630548a
This commit is contained in:
hanna 2011-02-01 16:29:31 +00:00
parent 027c91871f
commit 25f045cac6
1 changed files with 12 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
java/src/org/broadinstitute/sting/utils/file/FSLockWithShared.java
View File

@ -51,6 +51,7 @@ public class FSLockWithShared {
* Get a shared (read) lock on a file * Get a shared (read) lock on a file
* Cannot get shared lock if it does not exist * Cannot get shared lock if it does not exist
* @return boolean true if we obtained a lock * @return boolean true if we obtained a lock
* @throws FileSystemInabilityToLockException in cases of unexpected failure to capture lock.
*/ */
public boolean sharedLock() throws FileSystemInabilityToLockException { public boolean sharedLock() throws FileSystemInabilityToLockException {
@ -59,27 +60,27 @@ public class FSLockWithShared {
channel = new RandomAccessFile(file, "r").getChannel(); channel = new RandomAccessFile(file, "r").getChannel();
} }
catch (IOException e) { catch (IOException e) {
logger.debug("Unable to lock file (could not open read only file channel)"); logger.warn(String.format("WARNING: Unable to lock file %s (could not open read only file channel)",file.getAbsolutePath()));
return false; return false;
} }
// get shared lock (third argument is true) // get shared lock (third argument is true)
try { try {
lock = channel.tryLock(0, Long.MAX_VALUE, true); lock = channel.tryLock(0, Long.MAX_VALUE, true);
if (lock == null) { if (lock == null) {
logger.debug("Unable to lock file because there is already a lock active."); logger.warn(String.format("WARNING: Unable to lock file %s because there is already a lock active.",file.getAbsolutePath()));
return false; return false;
} }
} }
catch (ClosedChannelException e) { catch (ClosedChannelException e) {
logger.debug("Unable to lock file because the file channel is closed."); logger.warn(String.format("WARNING: Unable to lock file %s because the file channel is closed.",file.getAbsolutePath()));
return false; return false;
} }
catch (OverlappingFileLockException e) { catch (OverlappingFileLockException e) {
logger.debug("Unable to lock file because you already have a lock on this file."); logger.warn(String.format("WARNING: Unable to lock file %s because you already have a lock on this file.",file.getAbsolutePath()));
return false; return false;
} }
catch (IOException e) { catch (IOException e) {
logger.debug("Unable to lock file: " + e.getMessage()); logger.warn(String.format("WARNING: Unable to lock file %s: %s.",file.getAbsolutePath(),e.getMessage()));
if(throwExceptionOnUnknownFailure) if(throwExceptionOnUnknownFailure)
throw new FileSystemInabilityToLockException(e.getMessage(),e); throw new FileSystemInabilityToLockException(e.getMessage(),e);
else else
@ -91,6 +92,7 @@ public class FSLockWithShared {
/** /**
* Get an exclusive lock on a file * Get an exclusive lock on a file
* @return boolean true if we obtained a lock * @return boolean true if we obtained a lock
* @throws FileSystemInabilityToLockException in cases of unexpected failure to capture lock.
*/ */
public boolean exclusiveLock() throws FileSystemInabilityToLockException { public boolean exclusiveLock() throws FileSystemInabilityToLockException {
@ -99,7 +101,7 @@ public class FSLockWithShared {
channel = new RandomAccessFile(file, "rw").getChannel(); channel = new RandomAccessFile(file, "rw").getChannel();
} }
catch (Exception e) { catch (Exception e) {
logger.debug("Unable to lock file (could not open read/write file channel)"); logger.warn(String.format("WARNING: Unable to lock file %s (could not open read/write file channel)",file.getAbsolutePath()));
// do we need to worry about deleting file here? Does RandomAccessFile will only create file if successful? // do we need to worry about deleting file here? Does RandomAccessFile will only create file if successful?
return false; return false;
} }
@ -108,21 +110,21 @@ public class FSLockWithShared {
try { try {
lock = channel.tryLock(0, Long.MAX_VALUE, false); lock = channel.tryLock(0, Long.MAX_VALUE, false);
if (lock == null) { if (lock == null) {
logger.debug("Unable to lock file because there is already a lock active."); logger.warn(String.format("WARNING: Unable to lock file %s because there is already a lock active.",file.getAbsolutePath()));
return false; return false;
} }
else return true; else return true;
} }
catch (ClosedChannelException e) { catch (ClosedChannelException e) {
logger.debug("Unable to lock file because the file channel is closed."); logger.warn(String.format("WARNING: Unable to lock file %s because the file channel is closed.",file.getAbsolutePath()));
return false; return false;
} }
catch (OverlappingFileLockException e) { catch (OverlappingFileLockException e) {
logger.debug("Unable to lock file because you already have a lock on this file."); logger.warn(String.format("WARNING: Unable to lock file %s because you already have a lock on this file.",file.getAbsolutePath()));
return false; return false;
} }
catch (IOException e) { catch (IOException e) {
logger.debug("Unable to lock file: " + e.getMessage()); logger.warn(String.format("WARNING: ßUnable to lock file %s: %s.",file.getAbsolutePath(),e.getMessage()));
if(throwExceptionOnUnknownFailure) if(throwExceptionOnUnknownFailure)
throw new FileSystemInabilityToLockException(e.getMessage(),e); throw new FileSystemInabilityToLockException(e.getMessage(),e);
else else